polbin: Actually dump FlatGFA binary files #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
polbin
binary can both read and write two formats: text GFA files and "FlatGFA" binary files. So these four commands are possible:I also added test environments to check both kinds of round-tripping (through in-memory FlatGFA and through an on-disk file). It all works!!!!!
Conversion seems to be decently fast on these small examples. For our go-to big example,
chr8.pan.gfa
(4.2 GB), one run of conversion on my rapidly aging Intel iMac took 1m8s for parsing (GFA -> FlatGFA) and 1m44s for pretty-printing (FlatGFA -> GFA). Seems within the ballpark of reasonableness? (Moreover, the GFA seems to have round-tripped successfully. FWIW, just runningdiff
to check took 22s.)